microlinkhq / browserless / 29433523371

79%

push

github

fix(pdf): navigation-tolerant readiness gate; skip screenshot poll for painted pages (#837)

* fix(pdf): navigation-tolerant readiness gate; skip screenshot poll for painted pages

prepare()'s `auto` mode gated readiness on a screenshot poll (waitUntilAuto):
screenshot -> isWhite? -> repeat. Two problems in the GPU-less fleet (llvmpipe):
the screenshots are software-rasterized (seconds each), and the poll throws
`Execution context was destroyed` / `Target closed` when a page client-navigates
under it (SPAs re-commit their own URL after load), failing the whole render.

Add `waitForReady` to @browserless/screenshot: a navigation-tolerant gate that
resolves once the page is visually quiet (document height stable, every image
decoded, readyState complete) held for `quietMs`, taking no screenshots. When
`page.evaluate` throws on a destroyed context it resets the quiet window and
keeps polling instead of failing.

prepare() now runs waitForReady first; real painted content (decoded images in a
document taller than the viewport) returns immediately, and only a page that
settles still-blank falls back to the original screenshot poll, preserving the
blank-SPA protection.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

* fix(pdf): gate fast path on settle; harden readiness gate; simplify poll

Address PR #837 review:

- Fast path in `waitUntilAuto` now requires `!ready.timedOut`. A gate that
  timed out never settled, so its partial snapshot can't be trusted to skip
  the blank-SPA screenshot poll (Cursor Bugbot).
- `waitForReady` fails fast on a non-number `timeout` instead of computing a
  NaN deadline and silently returning `timedOut: true` (CodeRabbit).

Cleanups from /simplify:

- Reuse `node:timers/promises` `setTimeout` instead of a hand-rolled `sleep`.
- Collapse the standalone white-screen check into the poll loop's first
  iteration — it screenshotted with identical options and no page change in
  between, wasting a software-ra... (continued)

691 of 850 branches covered (81.29%)

Branch coverage included in aggregate %.

98 of 169 new or added lines in 2 files covered. (57.99%)

3669 of 4446 relevant lines covered (82.52%)

112701.11 hits per line