agama-project / agama / 29411422067

83%

push

github

refactor(web): add missing `TranslatedString` types in user-facing text props (#3696)

## Summary

- Types user-facing text props as `TranslatedString` instead of plain
`string` across form, core, and page components, so untranslated
literals are rejected at compile time.
- Marks three already-untranslated row-actions labels ("Actions for %s"
in the connections, DASD, and zFCP tables) for translation and reported
them in https://bugzilla.suse.com/show_bug.cgi?id=1271404
- Fixes a type bug in `SelectableDataTable`: `itemActionsLabel` was
declared as `(d: T) => string | string`, which parses as a function type
only, even though a plain value is also accepted at runtime.

## Motivation

Plain string literals passed as props slip through the translation
linter and reach users in English only (related to
https://bugzilla.suse.com/show_bug.cgi?id=1269514, protected link). The
`TranslatedString` tagged type exists precisely to prevent that: it
turns a runtime i18n bug into a compile-time error, since text must go
through `_()` before a component accepts it.

The type was introduced in #2928 seven months ago (Agama v19), but
applying it to component props was overlooked: most user-facing text
props remained plain `string`. #3685 and #3688 recently started closing
that gap; this PR extends the coverage to the remaining user-facing text
props.

## What changed

One commit per component, so each change is easy to review and revert:

**Form components and validation**
- `CheckboxField`: `label`, `aria-label`
- `Fieldset`: `legend`
- `validation-helpers.ts`: all message parameters and return types, plus
the two forwarding helpers in `connection-form/validations.ts`

**Core and layout components**
- `SimpleDropdown`: `label`
- `ResizeHandle`: `label`
- `Loading`: `aria-label`
- `SelectableDataTable`: `itemActionsLabel` and the `label` handed to a
custom `itemActionsComponent`

**Page-specific components**
- `SoftwarePage`: section titles, button labels, empty-state... (continued)

4903 of 6839 branches covered (71.69%)

Branch coverage included in aggregate %.

25579 of 29829 relevant lines covered (85.75%)

124.24 hits per line