adobe / spectrum-web-components / 29402011359

96%

push

github

feat(close-button): migrate to 2nd-gen (#6410)

* chore(close-button): add structure for s2 migration (#6355)

* chore(close-button): add Cross400 and Cross500 icons

Add cross icon assets required for close-button l and xl sizes.

Co-authored-by: Cursor <cursoragent@cursor.com>

* feat(close-button): phase 2 swc scaffold

Add swc-close-button with minimal render, CSS, Storybook stories, and tests
for the phase 2 setup milestone.

Co-authored-by: Cursor <cursoragent@cursor.com>

* refactor(button): move static-color to ButtonBase and harden disabled clicks

Co-authored-by: Cursor <cursoragent@cursor.com>

---------

Co-authored-by: Cursor <cursoragent@cursor.com>

* feat(close-button): phase 3–4 API and accessibility (#6360)

* feat(close-button): phase 3–4 API stories, tests, and migration plan

Rebase onto close-button-migration after scaffold merge. Close-button
extends ButtonBase directly (no CloseButtonBase); hide inherited pending
controls in Storybook.

Co-authored-by: Cursor <cursoragent@cursor.com>

* refactor(close-button): use BUTTON_* constants from core in stories

Drop redundant CloseButton.VALID_SIZES and STATIC_COLORS aliases; close-button
shares the button size and static-color scale via ButtonBase.

Co-authored-by: Cursor <cursoragent@cursor.com>

* chore(close-button): stop hiding pending controls in Storybook

Inherited ButtonBase pending attributes are fine until pending moves off
ButtonBase; update migration plan to match.

Co-authored-by: Cursor <cursoragent@cursor.com>

* test(close-button): address API PR review feedback

Use template() for the slot-label Accessibility story example and add a
render-time test that accessible-label wins over slot text.

Co-authored-by: Cursor <cursoragent@cursor.com>

---------

Co-authored-by: Cursor <cursoragent@cursor.com>

* feat(close-button): S2 styling and Storybook docs (#6385)

* feat(close-button): migrate S2 styling and focus treatment

Port spectrum-two close-button visuals to close... (continued)

6019 of 6462 branches covered (93.14%)

Branch coverage included in aggregate %.

37903 of 39169 relevant lines covered (96.77%)

461.22 hits per line