ben-manes / caffeine / #5641

100%

master: 100%

push

github

Cancel an overdue pending future when the pacer reschedules

Pacer.schedule only cancelled the future it replaced on the not-yet-overdue
branch; an overdue-but-still-pending future (a delayed task, or a
fire-time-rejected scheduler future) was replaced without cancelling, so its
task could still fire a redundant (idempotent) maintenance pass. Cancel
whenever a non-null future is replaced.

Also documents the accepted fire-time scheduler-rejection best-effort: a JDK
delayedExecutor limitation orphans the pacer future on a fire-time executor
rejection (self-heals within one cycle; within the amortized-expiration
envelope).

4143 of 4154 branches covered (99.74%)

1 of 1 new or added line in 1 file covered. (100.0%)

8414 of 8417 relevant lines covered (99.96%)

1.0 hits per line