ben-manes / caffeine / #5640

100%

master: 100%

push

github

Match the bounded cache on the vanished-key refresh discard

UnboundedLocalCache.remap discarded a refresh unconditionally on the
absent+null path, so replaceAll racing a concurrent remove + re-refresh
killed a token registered after the removal — where BoundedLocalCache
returns early without discarding for a non-creating caller. A vanished
key is a skip, not a mutation, so the refresh it raced (none) must not
be cancelled. Thread a computeIfAbsent flag (false for replaceAll and
computeIfPresent, true for compute and merge) and return early without
discarding on the absent branch when creation is disallowed; a creating
caller that returns null still discards, as before.

4145 of 4154 branches covered (99.78%)

4 of 4 new or added lines in 1 file covered. (100.0%)

8415 of 8418 relevant lines covered (99.96%)

1.0 hits per line