dangernoodle-io / breadboard / 29381192639

96%

push

github

fix: collapse the WiFi-creds write/heal/seed split-brain onto bb_settings (B1-708) (#873)

The WiFi credential WRITE lived on bb_nv (private RTC_NOINIT mirror) while
bb_settings owned the READ path -- they agreed only by comment, and the
boot-time heal/seed policy that strands a board if inverted sat entirely
inside an untested #ifdef ESP_PLATFORM block. This unifies both onto
bb_settings so the write and the heal are one path.

- move the creds WRITE off bb_nv: bb_prov (/save) and bb_wifi's 6
  pending-creds call sites now call bb_settings_wifi_set() /
  bb_settings_wifi_pending_* instead of bb_nv_config_set_wifi /
  _set_wifi_pending; drop bb_nv from bb_prov PRIV_REQUIRES. Closes the
  split where a re-provision left bb_nv's boot-read RTC mirror stale
  (B1-935)
- extract the heal-vs-seed boot policy into a pure bb_nv_creds_boot_decide()
  (mirrors bb_diag_reset_decision.c), host-tested against all 4 input
  combinations with a bite-proof RED run (inverted HEAL<->SEED fails 3
  tests); bb_nv_config_init now calls it and does only the espidf-only
  NVS/RTC-mirror I/O for whichever action comes back, and seeds the RTC
  mirror on the write path
- repoint the three misleading seed-gate tests to drive the same decision
  function against real bb_settings/bb_storage_rtc state, instead of
  asserting only the precondition readers
- fold in the bb_storage_rtc ssid/pass NUL-termination fix on the
  truncation branches (B1-948), now live on the heal read path
- move bb_nv_wifi_pending.c under components/bb_nv/src/ alongside the new
  decision file -- bbtool's scaffold derivation picks EITHER a component's
  flat *.c files OR its src/ dir, never both, so leaving wifi_pending.c
  flat silently dropped it from the native test build once src/ existed
- add a Kconfig range floor to BB_STORAGE_TXN_MAX_KEYS /
  BB_STORAGE_TXN_VALUE_MAX_BYTES coupling them to bb_storage_rtc's fixed
  field widths, so the baseline's structurally-unreachable uncovered-line
  entry (bb... (continued)

6958 of 7593 branches covered (91.64%)

Branch coverage included in aggregate %.

31 of 31 new or added lines in 3 files covered. (100.0%)

11667 of 11922 relevant lines covered (97.86%)

2422.86 hits per line