Freegle / Iznik / 27180

72%

Build Type

push

circleci

Committed by invalid-email-address

Commit Message

fix(voicepost-experiment): record conversion for both arms at post creation

The mobile-compose-variant experiment could not measure its headline
metric (does the voice option get more posts completed than control?).
recordConversion was only ever called on voicepost.vue, so:
  - control (986 exposures) recorded ZERO conversions — its typed flow
    never knew it was in the experiment; and
  - voice recorded conversion at review-finish, BEFORE the post is
    actually created (the user still has to complete the final
    "Freegle it!" step), inflating and mis-timing it.

So the two arms were measured at different funnel points, or not at all.

Both arms converge on give/mobile/whereami's "Freegle it!" (freegleIt),
which is what actually creates the post. Stash the assigned variant at
compose entry (markConversionPending) and record the conversion there
for whichever arm is pending (recordConversionIfPending), after a
successful freegleIt. Gated on the marker, so non-experiment posts are
unaffected; cleared after recording so a conversion counts at most once.
Removes voice's premature recordConversion('voice').

Adds unit coverage for the persist/record-at-completion helpers.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_016wNUPN1VyMifaL8hkwxvz9

Coverage Stats

13040 of 17189 branches covered (75.86%)

Branch coverage included in aggregate %.

28 of 59 new or added lines in 4 files covered. (47.46%)

2 existing lines in 2 files now uncovered.

136436 of 189497 relevant lines covered (72.0%)

37.88 hits per line