open-quantum-safe / liboqs / 29353124580
82%

DEFAULT BRANCH: main
Ran
Jobs 3
Files 2931
Run time 6min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 82.334% (+0.04%) from 82.299%
29353124580

push

github

web-flow 
Add API support for External-MU Signature[ML-DSA] (#2366)

* add API for external-MU signing (ML_DSA)

Signed-off-by: Abhi S <saxena_abhinav@icloud.com>

* code formatting

Signed-off-by: Abhi S <saxena_abhinav@icloud.com>

* fix issues

Signed-off-by: Abhi S <saxena_abhinav@icloud.com>

* add upstream changes to support extmu variant

Signed-off-by: Abhi S <saxena_abhinav@icloud.com>

* fix verify functions for x86

Signed-off-by: Abhi S <saxena_abhinav@icloud.com>

* avoid duplication of src compilation for mu variants

Signed-off-by: Abhi S <saxena_abhinav@icloud.com>

* fix multiple definition error

Signed-off-by: Abhi S <saxena_abhinav@icloud.com>

* add missed upstream changes

Signed-off-by: Abhi S <saxena_abhinav@icloud.com>

* fix CMake indentation issues

Signed-off-by: Abhi S <saxena_abhinav@icloud.com>

* add check for msglen for mu variants

Signed-off-by: Abhi S <saxena_abhinav@icloud.com>

* upstream sig fixes

Signed-off-by: Abhi S <saxena_abhinav@icloud.com>

* skip mem tests for extmu variants

Signed-off-by: Abhi S <saxena_abhinav@icloud.com>

* fix msg length issues for mu variant

Signed-off-by: Abhi S <saxena_abhinav@icloud.com>

* remove un-needed changes

Signed-off-by: Abhi S <saxena_abhinav@icloud.com>

* review fixes & change mu tests from internal APIs to external

Signed-off-by: Abhi S <saxena_abhinav@icloud.com>

* code formatting

Signed-off-by: Abhi S <saxena_abhinav@icloud.com>

* fix build issues

Signed-off-by: Abhi S <saxena_abhinav@icloud.com>

* remove unused param

Signed-off-by: Abhi S <saxena_abhinav@icloud.com>

* code formatting fix

Signed-off-by: Abhi S <saxena_abhinav@icloud.com>

* remove hardcoding of 64 as mu length

Signed-off-by: Abhi S <saxena_abhinav@icloud.com>

* address more review comments

Signed-off-by: Abhi S <saxena_abhinav@icloud.com>

* remove kat changes for ext-mu variants

Signed-off-by: Abhi S <saxena_abhinav@icloud.com>

* dummy commit to restart tests

Signed-off-by: Abhi S <saxena_... (continued)

285 of 344 new or added lines in 7 files covered. (82.85%)

22 existing lines in 15 files now uncovered.

210531 of 255705 relevant lines covered (82.33%)

8125538.82 hits per line

Uncovered Changes

Lines Coverage ∆ File
41
75.03
 -0.83% tests/vectors_sig.c
6
88.68
 src/sig/ml_dsa/sig_ml_dsa_44_extmu.c
6
88.68
 src/sig/ml_dsa/sig_ml_dsa_65_extmu.c
6
88.68
 src/sig/ml_dsa/sig_ml_dsa_87_extmu.c

Coverage Regressions

Lines Coverage ∆ File
5
94.44
 -4.63% src/kem/kyber/pqcrystals-kyber_kyber768_ref/indcpa.c
2
75.22
 -1.77% src/kem/hqc/pqc-hqc_hqc-1_ref/vector.c
2
76.11
 -1.77% src/kem/hqc/pqc-hqc_hqc-3_ref/vector.c
2
75.03
 -0.83% tests/vectors_sig.c
1
96.08
 -1.96% src/kem/classic_mceliece/pqclean_mceliece348864_avx2/encrypt.c
1
97.96
 -2.04% src/kem/classic_mceliece/pqclean_mceliece460896_avx2/encrypt.c
1
96.72
 -1.64% src/kem/classic_mceliece/pqclean_mceliece460896f_clean/encrypt.c
1
95.53
 -0.09% src/sig/falcon/pqclean_falcon-padded-512_avx2/keygen.c
1
33.33
 -4.17% src/sig/ml_dsa/mldsa-native_ml-dsa-44_x86_64/mldsa/src/rounding.h
1
33.33
 -4.17% src/sig/ml_dsa/mldsa-native_ml-dsa-65_aarch64/mldsa/src/rounding.h
1
98.53
 -1.47% src/sig/ml_dsa/mldsa-native_ml-dsa-65_x86_64/mldsa/src/packing.c
1
62.72
 2.46% src/sig/ml_dsa/mldsa-native_ml-dsa-65_x86_64/mldsa/src/sign.c
1
95.83
 -4.17% src/sig/ml_dsa/mldsa-native_ml-dsa-87_ref/mldsa/src/rounding.h
1
93.55
 -1.61% src/sig/uov/pqov_ov_Is_pkc_skc_avx2/ov.c
1
95.65
 -2.17% src/sig/uov/pqov_ov_Is_ref/ov.c
Jobs
ID Job ID Ran Files Coverage
1 x64-generic - 29353124580.1 1304
85.5
 GitHub Action Run
2 arm64-distbuild - 29353124580.2 1840
60.85
 GitHub Action Run
3 x64-distbuild - 29353124580.3 2394
56.96
 GitHub Action Run
Source Files on build 29353124580