FlexMeasures / flexmeasures / 29344504187

82%

push

github

Fix broken column sorting on the assets listing page (#2314)

* feat: stop mandating zero to be included in the domain of event values in the chart for multiple sensors

Signed-off-by: F.N. Claessen <claessen@seita.nl>

* docs: changelog entry

Signed-off-by: F.N. Claessen <claessen@seita.nl>

* feat: make including zero in a chart's y-axis a per-plot option

Rather than dropping zero from every axis, sensors_to_show plots take an
optional include-zero boolean (default true). A sub-plot's shared y-axis only
drops zero when all of its plots opt out, and opting out also lifts the forced
[0, 105] domain on percentage sensors. Editable per plot in the graph editor.

Also fixes the graph editor bootstrapping its state from a repr()'d
sensors_to_show: a Python False is not valid JSON, so JSON.parse threw and left
the modal empty. Jinja's tojson filter handles booleans (and None) correctly.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01G6LdvRHtFA6iacQQDE5eLS
Signed-off-by: F.N. Claessen <claessen@seita.nl>

* Fix broken column sorting on the assets listing page

Clicking ID/Name/Account headers failed silently because floatThead's
cloned sticky header (applied globally to every <table>) intercepted
pointer events over the real DataTables-bound header cells. Also fix
sorting by Account to order by the account's name (via a correlated
scalar subquery) instead of its arbitrary account_id.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01C2JTqYVFPmJgX7kN2DSvbE

* Fix sorting when combined with the assets search filter

Two bugs surfaced when sort_by/sort_dir was combined with a search
filter (which routes through a UNION ALL of private/public asset
queries):

- ID and Name sorting silently had no effect, because ORDER BY was
  applied to the individual UNION ALL members instead of the combined
  outer query; per SQL, ordering a union member doesn'... (continued)

8 of 9 new or added lines in 1 file covered. (88.89%)

14586 of 17883 relevant lines covered (81.56%)

0.82 hits per line