kobotoolbox / kpi / 29344763700

82%

master: 76%

Build Type

push

github

Committed by web-flow

Commit Message

perf(asset): fetch permissions once in Asset detail endpoint DEV-1833 (#7238)

### 📣 Summary

Opening a single project or collection is a bit faster — the server does
less redundant work per request.

### 📖 Description

When you open a project or collection, the server was preparing its
permission information twice. It now does that once, so detail pages
load slightly faster. Nothing changes in what you see.

### 💭 Notes

- The Asset **detail** endpoint fetched permission assignments **twice**
— once in `get_permissions()`, once in the `get_access_types()`
fallback. Added a per-request memoized helper so both share **one**
query (verified 2→1 with `CaptureQueriesContext`).
- Output is unchanged: the shared fetch is a superset each method
narrows in-memory. The list path is untouched (it uses the viewset
cache).

Added a regression test
(`test_detail_access_types_reuses_permission_fetch`) that fails if the
fields stop sharing the fetch. Green on both settings axes, darker
clean, no schema drift.

### 👀 Preview steps

1. ℹ️ have an account with a project or collection, and turn on SQL
query logging (Django debug toolbar, or log `django.db.backends`)
2. `GET /api/v2/assets/<uid>/` for that asset
3. 🔴 [on main] the object-permission table is queried **twice** for that
request
4. 🟢 [on PR] it is queried **once**, and the response body is identical

Coverage Stats

9332 of 12658 branches covered (73.72%)

1 of 7 new or added lines in 1 file covered. (14.29%)

2493 existing lines in 92 files now uncovered.

30355 of 37241 relevant lines covered (81.51%)

5.52 hits per line