ben-manes / caffeine / #5629

100%

master: 100%

Build Type

push

github

Committed by ben-manes

Commit Message

Match Guava's null-rejection in the adapter's asMap().replace

The facade's asMap().replace(K, V, V) short-circuited on the old-value
guard first, so replace(null, null, v) and replace(k, null, null)
returned false where Guava throws. Guava's LocalCache.replace checks
the key and new value for null before considering the old value; do the
same so the null corners reject rather than silently no-op. The
existing null-old-value case (replace(k, null, v) -> false) is
unchanged. Pinned by a CaffeinatedGuavaTest parity case run against
both the adapter and a real Guava cache.

Coverage Stats

4136 of 4150 branches covered (99.66%)

2 of 2 new or added lines in 1 file covered. (100.0%)

7 existing lines in 2 files now uncovered.

8406 of 8414 relevant lines covered (99.9%)

1.0 hits per line