ben-manes / caffeine / #5628

100%

master: 100%

push

github

Fix simulator eviction counts and reader sibling divergences

Eviction metric (hit rate unaffected -- hits/misses are recorded
independently):
- ArcPolicy: case (i) of onMiss deletes an LRU T1 page directly from
  the cache but never recorded it, so a scan reported ~0 evictions
  while thousands were paged out. Record it, like the evict() helper.
- TwoQueuePolicy: reclaimFor recorded an eviction on the OUT-queue
  overflow -- dropping an already non-resident identifier -- instead of
  the IN->OUT page-out that actually evicts a resident entry. Move the
  record to the page-out, so the count no longer trails by OUT hits and
  residual OUT occupancy.

Reader sibling consistency:
- CambridgeTraceReader ignored the MSR disk-number column, so
  concatenated multi-volume files aliased the same block across disks.
  Namespace keys by disk like the other SNIA block readers (single-file
  runs have a constant disk number, so their hit rate is unchanged).
- LibCacheSim csv/twitter readers emitted weight 0 for a zero-size
  object (making it eviction-exempt); floor at 1 to match the binary
  sibling reader.

4139 of 4150 branches covered (99.73%)

8411 of 8412 relevant lines covered (99.99%)

1.0 hits per line