kiva / ui / 29286863150

85%

push

github

feat(MP-3036): add AI loan pills to the goal recommended-loan card (#7056)

* feat(MP-3036): AI loan pills on the RecommendLoanForGoal card

Show an AI loan "pill" on the recommended-loan card across all three
goal-setting surfaces (goal-setting page, checkout thanks page, and the
My Kiva goal modal), which share the useGoalSettingRecommendedLoan
composable, so a single change covers every entry point.

Composable (useGoalSettingRecommendedLoan):
- Fetch AI pills for the current recommended loan via
  fetchAiLoanPills(apollo, [loanId]) in a watch on recommendedLoan.id;
  a stale-response guard ignores late responses after the loan advances.
- Expose the pills to the card as customCallouts. When pills exist, blank
  the loan's own callout sources (activity/sector/tags/themes) via a
  dedicated recommendedLoanForCard computed so the card renders only the
  pills; fall back to the loan's own callouts when there are none or the
  query errors.
- Fold pills-loading into isLoadingRecommendedLoan (now a computed of a
  loan-data flag and a pills flag) so the card waits behind the existing
  skeleton and appears once, avoiding a callout "pop".
- Keep the card-facing loan a separate computed so its reference stays
  stable across basket/route changes and the card is not re-processed.
- Expose the raw recommendedLoan (never blanked) for domain actions;
  add-to-basket emits this instead of the display-blanked card loan so
  downstream flows that read loan data (e.g. themes on the added-to-basket
  confirmation) keep their values.

Hosts:
- GoalSettingContainer: forward the injected apollo into the composable
  (was omitted, causing a fetch-time TypeError) and pass showPage as a
  reactive ref (was a bare boolean, causing an "Invalid watch source"
  warning). Emit the raw recommended loan on add-to-basket.
- GoalSettingModal / ThanksPageSingleVersion: emit the raw recommended
  loan on add-to-basket.

Tests:
- useGoalSettingRecommendedLoan spec: pills present/ab... (continued)

5973 of 6638 branches covered (89.98%)

Branch coverage included in aggregate %.

96 of 99 new or added lines in 4 files covered. (96.97%)

48400 of 57652 relevant lines covered (83.95%)

31.7 hits per line