ruby-grape / grape / 29257267196

97%

master: 97%

Pull #2796

github

Remove Grape::Util::ReverseStackableValues

Since #2795 internalized namespace_reverse_stackable into
InheritableSetting, ReverseStackableValues had a single consumer holding
exactly two keys (rescue_handlers / base_only_rescue_handlers). Its only
job was reverse-order chain traversal, but InheritableSetting already
tracks the same chain through #parent.

Replace the store with a plain per-scope Hash of rescue_from
registrations and merge it recursively over #parent. Hash#merge natively
yields the ordering Middleware::Error's find-based scan depends on: the
nearest scope's keys first (registration order preserved within a
scope), inherited keys appended, nearer handler winning on collision.

InheritableSetting#to_hash now exposes the merged rescue_handlers /
base_only_rescue_handlers instead of a namespace_reverse_stackable key.

Also drops the per-layer ReverseStackableValues allocation and the
intermediate arrays StackableValues#[] built on every read.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

1142 of 1236 branches covered (92.39%)

Branch coverage included in aggregate %.

3617 of 3685 relevant lines covered (98.15%)

22962.9 hits per line