agama-project / agama / 29261150940

83%

push

github

Fix detection of hardware RAIDs in /api/system (#3719)

## Problem

The list of existing storage devices (read from the libstorage-ng
devicegraph) is exported as part of `/api/system`. In that
representation, the BIOS-based RAIDs (a.k.a. hardware RAIDs) are
represented as "drives" since they are fully equivalent to a disk.

But the logic to detect when a drive is a BIOS RAID was wrong. The code
actually checked whether it was a DM RAID, which is a legacy kind of
RAID not even supported in recent versions of SUSE and/or openSUSE.

As a consequence, the UI was failing is shown here.

<img width="1019" height="620" alt="hardware-raid-wrong"
src="https://github.com/user-attachments/assets/355c7a93-b87c-43d9-854f-6c2e0717138a"
/>


## Solution

Use the correct method to check if the RAID is based on BIOS/hardware.
That proper check returns `true` for the deprecated DM RAIDs but also
for any other kind of BIOS RAID.

As a result, the UI works again and the RAID can be selected just as a
regular disk.

<img width="1028" height="648" alt="hardware-raid"
src="https://github.com/user-attachments/assets/79747c2c-a84d-4c35-9b45-f803071746ed"
/>


## Testing

- Added a new unit test
- Tested manually using a devicegraph from a bug report (as seen in the
screenshots).

4903 of 6839 branches covered (71.69%)

Branch coverage included in aggregate %.

2 of 2 new or added lines in 1 file covered. (100.0%)

25577 of 29827 relevant lines covered (85.75%)

124.11 hits per line