ben-manes / caffeine / #5621

100%

master: 100%

push

github

Wrap jcache copier failures as CacheException across CacheProxy

CacheProxy.get/getAll propagated a store-by-value copier's non-
CacheException RuntimeException raw, while LoadingCacheProxy wrapped it,
so the same call surfaced a different exception type depending on whether
the cache was read-through. Per JSR-107 each operation @throws
CacheException on a problem fetching/doing, and the RI's read-copy
(fromInternal) throws CacheException.

Fold the copy helpers behind a single copyOf that rethrows
NPE/ISE/CCE/CacheException raw and wraps any other RuntimeException in
CacheException, so every method (get/getAll/getAnd*/put*/replace*/
iterator) is consistent; the copier is the only user-pluggable
non-CacheException vector. copyOf is strict (non-null parameter) so
NullAway enforces the assumed non-null at each call site, and the three
getAndX prior-value returns guard the null explicitly. The loader
adapter's own copy stays CacheLoaderException (a CacheException subtype,
correct for the load flow).

4143 of 4154 branches covered (99.74%)

18 of 18 new or added lines in 2 files covered. (100.0%)

8412 of 8413 relevant lines covered (99.99%)

1.0 hits per line