ben-manes / caffeine / #5620

100%

master: 100%

push

github

Keep jcache reload expiry unchanged on null/throwing update policy

JCacheLoaderAdapter.expireTimeMillis called duration.isZero() without a
null guard, so a getExpiryForUpdate() of null (the CreatedExpiryPolicy /
AccessedExpiryPolicy / default EternalExpiryPolicy behavior) NPE'd into
the catch and returned MAX_VALUE, making a refreshed finite-expiry entry
eternal (plus a WARNING per refresh).

The helper now takes a boolean created, mirroring
CacheProxy.getWriteExpireTimeMillis: a null or throwing update returns
the MIN_VALUE "unchanged" sentinel that reload remaps to the prior
expiry; creation keeps null/throw as eternal so the loaded entry is not
lost. reload is an update (it receives oldValue), so this matches the
put/replace update paths, which also leave a null or throwing update
expiry unchanged; only the insert path is eternal-on-throw.

4141 of 4152 branches covered (99.74%)

10 of 10 new or added lines in 1 file covered. (100.0%)

8416 of 8417 relevant lines covered (99.99%)

1.0 hits per line