ben-manes / caffeine / #5615

100%

master: 100%

push

github

Copy read-through stores under store-by-value

Under store-by-value, LoadingCacheProxy.get/getAll stored the caller's
key and JCacheLoaderAdapter.load/loadAll/reload stored the loader's
value without copying, unlike every other store site. A mutable key
mutated after a read-through get corrupted the stored key, and a loader
that retained its returned value could later mutate the stored entry.
The RI copies both key and value, and Caffeine's own invoke path copies
the loaded value, so read-through was the outlier.

Copy the key at the proxy boundary and the value in the adapter before
wrapping it in Expirable. Create the copier once in the cache factory
and pass it into CacheProxy and the adapter instead of building it
twice.

4125 of 4134 branches covered (99.78%)

28 of 28 new or added lines in 4 files covered. (100.0%)

8401 of 8401 relevant lines covered (100.0%)

1.0 hits per line