ben-manes / caffeine / #5614

100%

master: 100%

Build Type

push

github

Committed by ben-manes

Commit Message

Probe quietly in the async VarExpiration putIfAbsent

BoundedVarExpiration.putIfAbsentAsync probed for a present entry with a
non-quiet cache.getIfPresent, which runs the read path through the
cache's configured AsyncExpiry and so applies the user's expireAfterRead
to the existing entry. A present-entry putIfAbsent then rewrote the
entry's expiration, violating the "no effect on the duration if the
entry was present" contract. The synchronous path routes the same probe
through FixedExpireAfterWrite, whose read leg is identity, so it never
recomputes the duration.

Probe with getIfPresentQuietly instead; the retries were already quiet,
so the loop-carried priorFuture collapses into the loop. This does not
apply to AsMapView.putIfAbsent, whose synchronous counterpart passes the
user Expiry and so correctly consults expireAfterRead on both paths.

Coverage Stats

4124 of 4134 branches covered (99.76%)

1 of 1 new or added line in 1 file covered. (100.0%)

1 existing line in 1 file now uncovered.

8385 of 8386 relevant lines covered (99.99%)

1.0 hits per line