databendlabs / openraft / 29146087220

87%

main: 87%

Build Type

push

github

Committed by drmingdrmer

Commit Message

fix: re-arm snapshot policy after an in-flight build completes

# Summary

A `SnapshotPolicy::LogsSinceLast` trigger that fired while a snapshot build was
already in flight was dropped, yet the policy still recorded the attempt. Once
the in-flight build finished nothing re-triggered a build, so on a quiescent
node the snapshot could stay arbitrarily far behind `committed` -- stalling
policy-gated log purge with it. The policy now records an attempt only when a
build is actually queued, so the dropped trigger re-fires on the first routine
check after the in-flight build completes.

# Details

- `RaftCore::trigger_snapshot` now reports whether a build was queued, and
  `trigger_routine_actions` advances `snapshot_tried_at` only when it was. A
  trigger dropped because a build is already in progress no longer advances the
  baseline `should_snapshot` compares against, so it stops suppressing the
  policy. Builds deferred by the state machine still record the attempt,
  preserving their existing threshold debounce.

- Add a deterministic single-node regression test: it holds one build in flight
  (which pins `applied`), drives `committed` past the threshold a second time
  with fire-and-forget writes, and asserts the snapshot converges to `committed`
  once the build completes.

- Fix: #1829

Coverage Stats

5 of 5 new or added lines in 1 file covered. (100.0%)

6 existing lines in 3 files now uncovered.

17466 of 20063 relevant lines covered (87.06%)

157939.39 hits per line