decentraland / social-service-ea / 29103608044

90%

main: 90%

Pull #432

github

refactor: drop undeliverable subscription stream close reasons

Only the duplicate-subscription rejection can actually deliver a close notice —
the connection is still alive there. Shutdown and stale-cleanup closes run after
the socket is gone, so their reasons never reached the client. Remove that dead
plumbing: the close-reason parameter on emitterToGenerator's destroy() (and its
getCloseReason accessor), the reason threading through subscribers-context
teardown paths, and the post-loop reason forwarding in handleSubscriptionUpdates.

The duplicate-subscription path (the one that works) is unchanged.

2354 of 2761 branches covered (85.26%)

Branch coverage included in aggregate %.

12 of 13 new or added lines in 7 files covered. (92.31%)

5881 of 6356 relevant lines covered (92.53%)

80.45 hits per line