decentraland / social-service-ea / 29098302998

90%

main: 90%

Build Type

Pull #432

github

Committed by LautaroPetaccio

Commit Message

feat: inform clients why a subscription stream is closed

Uses the new SubscriptionStreamClosed message from @dcl/protocol: before a
server-initiated close, the stream now yields a final message carrying a
close reason (and optional detail) instead of ending silently.

- emitterToGenerator: destroy() accepts an optional close reason, exposed
  via getCloseReason() so the consumer loop can act on it after draining.
- subscribers-context: teardown paths tag their reason — SERVER_SHUTTING_DOWN
  on stop, STALE_SUBSCRIPTION on both reconciliation sweeps — and
  removeConnection() forwards an optional caller-provided reason.
- handleSubscriptionUpdates: rejected duplicate subscriptions now tell the
  client why (DUPLICATE_SUBSCRIPTION) before closing, and destroys with a
  reason yield a final stream-closed message when the service provides a
  builder for it.
- All six subscribe services build the final message with fromPartial so it
  is protobuf-complete (zero-value defaults plus the notice).

Delivery is best-effort by nature: the final message only reaches clients
whose connection is still alive (duplicate rejection, shutdown drain);
teardowns triggered by an already-dead socket have no one to inform.

Pull Request Pull Request #432: feat: inform clients why a subscription stream is closed

Coverage Stats

2358 of 2765 branches covered (85.28%)

Branch coverage included in aggregate %.

25 of 26 new or added lines in 9 files covered. (96.15%)

7 existing lines in 3 files now uncovered.

5887 of 6362 relevant lines covered (92.53%)

80.7 hits per line