ruby-grape / grape / 29093919068

97%

master: 97%

Build Type

Pull #2791

github

Committed by ericproulx

Commit Message

Build helper routes from a settings copy, not shared mutation

add_head_not_allowed_methods_and_options_methods used
without_root_prefix_and_versioning to delete the root-prefix/versioning
keys from the shared class-level namespace_inheritable and restore them in
an ensure. Compilation runs when a fresh API instance is built, which can
happen at runtime (mount, helpers, or route definitions call change!) while
another instance is still serving. A request handled during that window
could observe the temporarily-missing keys — e.g. Instance#cascade? reads
namespace_inheritable[:version_options] and would fall back to true.

Read the settings the helper routes need from a local copy
(namespace_inheritable.to_hash minus the versioning keys) and pass it into
collect_route_config_per_pattern instead. Nothing in that path reads the
stripped keys, so behavior is unchanged, and the shared settings object is
no longer mutated during compilation.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

Pull Request Pull Request #2791: Build helper routes from a settings copy, not shared mutation

Coverage Stats

1116 of 1220 branches covered (91.48%)

Branch coverage included in aggregate %.

3 of 3 new or added lines in 1 file covered. (100.0%)

23 existing lines in 5 files now uncovered.

3562 of 3653 relevant lines covered (97.51%)

8688.04 hits per line