NVIDIA / holodeck / 29085367771

51%

Build Type

push

github

Committed by web-flow

Commit Message

fix(cli): migrate to urfave/cli v3 for natural flag/positional interleaving (#850)

* test(cli): add interspersed-flag regression test (RED, #813)

urfave/cli v2 stops flag parsing at the first positional, so
'holodeck skill add using-holodeck --claude' is rejected. Add a
regression test covering natural-order parsing, flag-first parsing,
and ssh '--' passthrough. The natural-order case fails under v2 and
drives the v3 migration.

Signed-off-by: Eduardo Arango <eduardoa@nvidia.com>
Signed-off-by: Carlos Eduardo Arango Gutierrez <eduardoa@nvidia.com>

* fix(cli): migrate cmd/cli from urfave/cli v2 to v3 (#813)

urfave/cli v2's default parser stops flag parsing at the first
positional, so natural-order invocations like
'holodeck skill add using-holodeck --claude' are rejected. v3 parses
flags and positionals interspersed, fixing #813.

Port the whole cmd/cli tree (root App -> Command, Run(ctx, args),
Action/Before signatures, ctx.* -> cmd.*, EnvVars -> Sources/EnvVars,
StringSlice destination -> []string, Subcommands -> Commands,
CustomAppHelpTemplate -> CustomRootCommandHelpTemplate with v3
template fields). The user-visible interface (command/flag names,
aliases, exit codes) is unchanged.

v3 consumes the "--" terminator and drops it from Args(), so ssh's
remote-command extraction becomes Args().Tail(); this preserves the
documented 'ssh <id> -- <command>' passthrough exactly (remote flags
survive) and is guarded by a mutation-checked test.

Drops v2 from go.mod and revendors (v2 and its now-unused transitive
deps removed).

Signed-off-by: Eduardo Arango <eduardoa@nvidia.com>
Signed-off-by: Carlos Eduardo Arango Gutierrez <eduardoa@nvidia.com>

* docs(cli): use natural-order skill examples now that v3 parses them (#813)

With the v2->v3 migration, 'holodeck skill add <name> --claude' parses,
so the #812 flag-first workaround examples are no longer needed. Update
the in-binary help (skill add / skill) and README to positional-first
ordering, and replac... (continued)

Coverage Stats

50 of 96 new or added lines in 16 files covered. (52.08%)

1 existing line in 1 file now uncovered.

6532 of 12776 relevant lines covered (51.13%)

0.57 hits per line