NVIDIA / holodeck / 29035530440

51%

Build Type

push

github

Committed by web-flow

Commit Message

test(e2e): credential-free mock E2E suite + real-AWS CI cap (1 PR / 2 post-merge / weekly matrix) (#844)

* feat(awsfake): add stateful in-memory fake for EC2, ELBv2, and SSM interfaces

AWS ships no official mocks for aws-sdk-go-v2; its documented testing
guidance is consumer-defined interfaces + DI + own fakes. This fake
implements holodeck's internal/aws interfaces (39 EC2 + 12 ELBv2 + 1 SSM
methods) over a mutex-guarded in-memory store with realistic lifecycle
semantics: SDK-waiter-compatible instance states, exact *.NotFound error
codes the provider's retry branches string-match, create/describe/delete
consistency, error injection (FailNext) and a call/input recorder.
Compile-time interface assertions make SDK shape changes fail the build.

Signed-off-by: Carlos Eduardo Arango Gutierrez <eduardoa@nvidia.com>

* refactor(aws): migrate provider unit tests to awsfake, drop hand-written mocks

Replaces the 494-line per-method-closure MockEC2Client (and the local
MockELBv2Client in nlb_delete_test.go) with the shared stateful fake.
Coverage envelope preserved 1:1 (155 subtests + 84 ginkgo specs before
and after); one previously vacuous owner-id assertion made real; adds
mutation-verified pinning tests for SG cross-reference revocation and
NLB listener->target-group->LB teardown order. Shared helpers move to
helpers_test.go.

Signed-off-by: Carlos Eduardo Arango Gutierrez <eduardoa@nvidia.com>

* feat(tests): add credential-free mock E2E suite behind provider option seam

11 specs (label 'mock') drive the real Provider.Create/Delete/DryRun
code against awsfake in ~2.4s with no AWS credentials or SSH key:
lifecycle for 4 topologies (single-node, minimal, dedicated-CP, HA+NLB),
rollback-on-injected-failure at 5 create phases asserting zero orphaned
resources, cluster partial-failure cleanup via Delete, idempotent
delete. newProvider gains an aws.Option passthrough; the suite-wide
E2E_SSH_KEY requirement moves to a per-spec requireRealAWSEnv guard;
the gi... (continued)

Coverage Stats

826 of 1220 new or added lines in 4 files covered. (67.7%)

10 existing lines in 2 files now uncovered.

6477 of 12778 relevant lines covered (50.69%)

0.56 hits per line