dangernoodle-io / breadboard / 29069468274

96%

push

github

feat: add callback_slot fence enforcing the bb_core callback-slot helper (#805)

- freeze the 7 remaining production hand-rolled single-slot-injected-callback sites (bb_wifi's grandfathered on_got_ip espidf seam + its Arduino r4/cc3000 backends, bb_ota_validator's on_validated hook, bb_pub's interval-apply hook) as a draining baseline

- new sites outside components/bb_core/include/bb_callback_slot.h's BB_CALLBACK_SLOT_RET/VOID0/VOID macros now fail make fence

- test-only hooks (#ifdef *_TESTING/*_TEST/UNIT_TEST-guarded) are scoped out of detection entirely, mirroring fence/_base.py's EXCLUDE_DIRS treatment of test/

- an #elif branch is always treated as production regardless of its own condition text, so a production slot in an #elif of a testing #ifdef is never silently dropped from the scan

- out of scope (documented accepted limitations): return-value+arg callbacks (no macro variant supports that shape) and ctx-carrying two-parameter setters (a different idiom the macro set doesn't cover)

- documents scripts/bbtool/README.md with a callback_slot family section

Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>

3313 of 3313 branches covered (100.0%)

Branch coverage included in aggregate %.

5259 of 5259 relevant lines covered (100.0%)

9691.36 hits per line