Freegle / Iznik / 25980

72%

Build Type

push

circleci

Committed by edwh

Commit Message

fix(modtools): rejecting a held post must clear heldby (Discourse 9894)

handleReject moved a copy to the Rejected collection (deleted stays 0) but never
cleared messages_groups.heldby, and never recomputed the message-level
messages.heldby. A rejected-but-held row kept messages.heldby pinned, so the whole
post showed "Held": a mod on another group the post rippled into saw a Release
button, could not reject their own copy, and Release could not clear it (the
"still held on any group?" check counted the rejected row). Clear heldby on the
rejected/deleted rows and recompute messages.heldby, mirroring handleReleaseHeld.
Test: TestRejectClearsHeldby. (Rows already stuck in prod were backfilled directly.)

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01VXKgf7Xquudc6CwP2RN6jX

Coverage Stats

12937 of 17046 branches covered (75.89%)

Branch coverage included in aggregate %.

7 of 7 new or added lines in 1 file covered. (100.0%)

11 existing lines in 2 files now uncovered.

135363 of 188454 relevant lines covered (71.83%)

37.96 hits per line