dangernoodle-io / breadboard / 29044283369

95%

push

github

refactor: bb_wifi backend-neutral disconnect-reason contract (stringified enum on the wire) (#797)

* refactor(bb_wifi): add portable disc_reason enum + esp/wl_status mapping

Adds bb_wifi_disc_reason_t (KB 820, PR1) as the backend-neutral
disconnect-reason contract, plus bb_wifi_map_esp_reason/bb_wifi_map_wl_status
pure mapping helpers and a rewritten bb_wifi_disc_reason_str keyed by the
enum instead of a raw backend-specific numeric code. BB_WIFI_REASON_BB_*
kept as deprecated aliases for source compat.

* refactor(bb_wifi): index reason_histogram by bb_wifi_disc_reason_t

wifi_reconn_state_t.reason_histogram shrinks from a raw uint8_t-keyed
256-entry array to a BB_WIFI_DISC_COUNT-entry array keyed by the portable
enum. wifi_reconn_policy_on_disconnect drops its handshake_reason_code
param -- callers pass the already-mapped enum and the handshake-tier
comparison is against BB_WIFI_DISC_HANDSHAKE_TIMEOUT directly.

* refactor(bb_wifi): wire disc_reason enum through every backend

espidf: bb_wifi_get_disconnect/wifi_reconn_get_disconnect now surface
bb_wifi_disc_reason_t; the STA_DISCONNECTED handler maps the raw esp
reason before logging/indexing the histogram. cc3000: always
BB_WIFI_DISC_UNKNOWN (no per-reason diagnostics on this backend). r4:
maps wl_status_t via bb_wifi_map_wl_status, resolving the prior
esp-reason-code numeric collision. host stub: histogram buffer/test
hooks resized to BB_WIFI_DISC_COUNT.

Hygiene (KB 820 PR1 scope): bb_wifi_ensure_netif -> bb_wifi_ensure_net_stack
(all call sites); bb_wifi_is_associated comment no longer names the esp
implementation call; esp_netif moves from bb_wifi's REQUIRES to
PRIV_REQUIRES (no public-header usage).

* refactor(bb_wifi): emit disc_reason as a stable string label on the wire

BREAKING CHANGE (KB 820, PR1): GET /api/wifi "disc_reason" and GET
/api/diag/net "last_disconnect_reason" change from raw numeric codes to
the portable bb_wifi_disc_reason_t label (e.g. "handshake_timeout",
"bb_lost_ip"... (continued)

3371 of 3371 branches covered (100.0%)

Branch coverage included in aggregate %.

8 of 8 new or added lines in 2 files covered. (100.0%)

5360 of 5360 relevant lines covered (100.0%)

9559.38 hits per line