hyperledger-labs / fabric-smart-client / 29018226511

81%

push

github

fix(fabric/db): open VaultStore.Store write transaction with BeginTx(ctx) (#1569)

Store already receives the request context and runs every statement with
ExecContext, but the enclosing write transaction is opened with Begin(),
so it is not rolled back when the request is canceled: the connection
stays checked out in idle-in-transaction state, holding a slot in the
bounded write pool. The read path (common/vault.go) already ties its
transactions to the context.

Open the transaction with BeginTx(ctx, nil) in the postgres and sqlite
vault stores, and declare BeginTx on the WriteDB interface; both
implementations already provide it through the embedded *sql.DB.

Signed-off-by: Evan <evanyan@sign.global>

2 of 2 new or added lines in 2 files covered. (100.0%)

28674 of 38834 relevant lines covered (73.84%)

2883.6 hits per line