chavic / rust-payjoin / 29016105762

86%

master: 86%

push

github

Expose proposal txid stability on receiver states

Monitor::check_for_transaction already knows the proposal's
transaction ID cannot be tracked when the sender contributed
non-SegWit inputs, and concludes the session as PayjoinProposalSent
without checking the network. That knowledge arrives too late for
receivers that record the expected transaction ID when handing out
the proposal, e.g. to reconcile an incoming payment: with a
non-SegWit sender input the recorded ID is silently wrong, because
the sender's final signature rewrites the script_sig and changes
the ID.

Expose the predicate Monitor uses as proposal_txid_is_stable() on
every state that holds the fallback transaction, and mirror it in
payjoin-ffi. Receivers can now pick a policy as soon as the
original payload is known: decline to contribute and let the
fallback pay, or reconcile that session by script instead of by
transaction ID.

6 of 6 new or added lines in 1 file covered. (100.0%)

13360 of 15558 relevant lines covered (85.87%)

350.45 hits per line