blevesearch / bleve / 29004356496

52%

Build Type

push

github

Committed by web-flow

Commit Message

bug: Close bolt on error when updating index (#2376)

- When updating an index with an updated mapping, we open bolt via
scorch's `OpenMeta` API but we never close it on error.
- The error case can happen if the user has given an invalid mapping or
if the updated mapping does not satisfy the criterion required for index
update.
- Scorch's `Close()` API handles the dual case:
    - If only bolt is opened but not scorch, it closes only bolt.
    - If both bolt and scorch is opened, it closes both.
- Fix the issue by always closing scorch on error, irrespective of
whether it was opened using `OpenMeta` or `Open` or `OpenMeta + Open`.

Coverage Stats

4 of 6 new or added lines in 1 file covered. (66.67%)

3 existing lines in 1 file now uncovered.

19837 of 37897 relevant lines covered (52.34%)

0.59 hits per line