Freegle / Iznik / 25722

72%

push

circleci

feat(apiv2): legacy image redirect endpoint - retires the last live V1 code

GET /image resolves the old *img_N.jpg URL forms (still hit ~3-5K/day from
old emails and external links via images.ilovefreegle.org) exactly as V1
Attachment::canRedirect did: externaluid rows 302 to the delivery proxy
(freegletusd- prefix stripped, rotate mod applied, w/h ignored as in V1),
externalurl rows 302 to the proxied external image, archived rows 302 to the
Azure archive URL for the five types V1 ever archived (img/mimg/fimg/cimg/
bimg - others fall through), and everything else including the pre-tusd
byte-serving rows 302s to the default profile image (plan Stage 4 decision:
default fallback instead of keeping DB-blob serving alive).

frontend-nginx.conf gains the images.ilovefreegle.org server block (app1's
rewrite map mirrored verbatim, targeting the apiv2 resolver; zimg_/beacons/
sw.js/api passthrough return 410 - dead with V1) and the one-line
users.ilovefreegle.org web redirect. Both inert until the HAProxy
default-backend cutover; nginx -t clean.

New misc helpers GetExternalImageDeliveryUrl / GetArchivedImageDeliveryUrl
unit-tested for exact URL forms; 8 endpoint tests cover every resolution
branch (fixtures via same-connection LastInsertId - the image tables' hash
column is varchar(16), too short for uniquePrefix markers).

Full Go suite via status API: 3439 passed, 0 failed.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_014V1ihELPDZSe3CWT461fyK

12916 of 17018 branches covered (75.9%)

Branch coverage included in aggregate %.

95 of 99 new or added lines in 3 files covered. (95.96%)

134863 of 186683 relevant lines covered (72.24%)

38.28 hits per line