orneryd / NornicDB / 28963827968

89%

main: 89%

Build Type

Pull #259

github

Committed by linuxdynasty

Commit Message

fix(cypher): carry relationship bindings through multi-MATCH and index-seed IN-list traversal starts

Two independent defects on the same query shape
(MATCH (s) WHERE s.uid IN $u MATCH (s)-[rel]->() WHERE
rel.evidence_source = $e DELETE|RETURN ...):

1. Correctness: a relationship variable bound by the second (or later)
   MATCH clause of a multi-MATCH query was silently dropped. `binding`
   (match_multi.go) is map[string]*storage.Node, so executeFirstMatch/
   executeChainedMatch never stored the relationship a clause's pattern
   bound even though the traversal's PathResult already carried it.
   DELETE rel deleted zero edges; RETURN rel / count(rel) / rel.prop /
   elementId(rel) resolved to nil while node columns in the same query
   were correct. Kept binding's map[string]*storage.Node shape unchanged
   (~10 existing binding_where_compile*_test.go-family tests construct
   and index it directly) and threaded relationship bindings as a
   parallel, index-aligned map[string]*storage.Edge through
   executeFirstMatch, executeChainedMatch, a new
   filterBindingsByWhereWithRels (reuses the untouched node-only WHERE
   compiler via a read-only bindingWithRelView property adapter), and
   resolveBindingExpr/resolveBindingItem. Also fixed executeMultiMatch
   never applying SKIP/LIMIT despite its own comment claiming it did.

2. Performance: MATCH (s:Label)-[rel]->() WHERE s.uid IN $list ... never
   index-seeded its start nodes, even though the equivalent node-only
   MATCH (s:Label) WHERE s.uid IN $list already does via
   tryCollectNodesFromPropertyIndexIn(Literal). Added
   tryCollectNodesFromPropertyIndexInCompound, wiring those existing
   index-seek helpers into executeMatchWithRelationshipsWithPath's
   start-node pruning chain, including when the IN-list is one AND
   conjunct alongside a relationship-property predicate (mirrors
   tryCollectNodesFromIDEqualityCompound's conjunct handling).
   filterPathsByWhere still re-evaluates the full WH... (continued)

Pull Request Pull Request #259: fix(cypher): bind relationships across multi-MATCH clauses; perf(cypher): index-seed IN-list traversal starts

Coverage Stats

147 of 157 new or added lines in 3 files covered. (93.63%)

19 existing lines in 6 files now uncovered.

146194 of 164009 relevant lines covered (89.14%)

1.04 hits per line