tari-project / tari / 28941219168
61%

DEFAULT BRANCH: development
Ran
Jobs 1
Files 703
Run time 2min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 61.951% (+1.0%) from 60.926%
28941219168

push

github

web-flow 
feat: add mined_in_epoch to burn claim proof file (#7919)

Description
---
Records the L1 epoch a burn was mined in (`mined_in_epoch = block_height
/ vn_epoch_length`) in the burn claim proof file the Minotari console
wallet writes.

The burn's L1 block height is not available at the write site, so it is
surfaced from the base node — which already has it when generating the
kernel Merkle proof — and threaded through to the console wallet:

- `KernelMerkleProof` and `GenerateKernelMerkleProofResponse` now carry
`block_height`. The RPC response field is `Option<u64>` with
`#[serde(default)]` so responses from older base nodes deserialize as
`None` rather than failing.
- The wallet relays the height via
`TransactionEvent::TransactionBurnConfirmed` (`mined_in_height`).
- The console wallet converts height → epoch using the network's
consensus constants
(`consensus_constants(height).block_height_to_epoch(height)`) and writes
`CompleteClaimBurnProof.mined_in_epoch` (`Option<u64>` +
`#[serde(default)]`).

No on-chain / consensus / engine change: `mined_in_epoch` lives only in
the off-chain proof **file** wrapper, not in the on-chain
`BurnClaimProof`.

Motivation and Context
---
An auto burn-claim client (Ootle walletd) currently has no way to know
which L1 epoch a burn belongs to — the proof references the L1 block by
hash only. As a result it can submit a claim before the base-layer
scanner has synced the burn's L1 header, which the base layer rejects as
not-yet-claimable. Embedding the mined epoch lets the claimant defer
submission until L2 has synced past that epoch.

Both new file/wire fields are `Option` + `#[serde(default)]`, so this
degrades cleanly in every direction: new wallet ↔ old base node (height
`None`), old reader ↔ new file (unknown field ignored), new reader ↔ old
file (field absent → `None`). Epoch-only relies on L1 and L2 sharing
`vn_epoch_length` (a shared consensus constant); the epoch is computed
from the burn's own height, not the cur... (continued)

41 of 63 new or added lines in 6 files covered. (65.08%)

37 existing lines in 11 files now uncovered.

72565 of 117133 relevant lines covered (61.95%)

223202.02 hits per line

Uncovered Changes

Lines Coverage ∆ File
10
0.0
 0.0% base_layer/wallet/src/transaction_service/protocols/fetch_claim_burn_merkle_proofs.rs
7
0.0
 0.0% base_layer/wallet/src/storage/sqlite_db/models.rs
3
0.0
 0.0% base_layer/wallet/src/transaction_service/storage/database.rs
2
38.51
 -0.03% base_layer/wallet/src/transaction_service/storage/sqlite_db.rs

Coverage Regressions

Lines Coverage ∆ File
17
53.38
 8.98% base_layer/core/src/chain_storage/lmdb_db/lmdb_db.rs
6
53.95
 6.41% base_layer/core/src/chain_storage/blockchain_database.rs
3
79.11
 -0.7% base_layer/transaction_components/src/validation/aggregate_body/aggregate_body_internal_validator.rs
2
38.51
 -0.03% base_layer/wallet/src/transaction_service/storage/sqlite_db.rs
2
85.05
 -0.71% comms/core/src/connection_manager/manager.rs
2
61.55
 -0.23% comms/core/src/connectivity/manager.rs
1
46.97
 33.33% base_layer/core/src/chain_storage/block_add_result.rs
1
25.29
 -1.15% base_layer/core/src/chain_storage/error.rs
1
66.67
 -0.28% base_layer/core/src/mempool/sync_protocol/mod.rs
1
75.34
 -1.37% base_layer/node_components/src/blocks/chain_block.rs
1
0.0
 0.0% base_layer/wallet/src/transaction_service/storage/database.rs
Jobs
ID Job ID Ran Files Coverage
1 28941219168.1 703
61.95
 GitHub Action Run
Source Files on build 28941219168