tari-project / tari / 28609564555
61%

DEFAULT BRANCH: development
Ran
Jobs 1
Files 702
Run time 2min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 60.926% (-0.9%) from 61.861%
28609564555

push

github

web-flow 
fix: reduce listening state log spam (#7905)

Description
---

Reduces repeated listening-state chain metadata debug logs by
aggregating peer metadata updates in the listening loop.

The listening state now collects peer chain metadata and emits a single
`DEBUG` summary on a timer, and when leaving the listening state.
Per-peer status details are still available at `TRACE`, so the useful
signal remains without spamming debug logs. Sync decisions are
unchanged.

Motivation and Context
---

Fixes #6808.

The previous debug log was emitted from `determine_sync_mode` for every
peer metadata update while the node was up to date, which could create
many identical debug entries.

How Has This Been Tested?
---

- `git diff --check`
- `cargo test --locked --ignore-rust-version -p tari_core
base_node::state_machine_service::states::listening --lib`
- `cargo check --locked --ignore-rust-version -p tari_core`

What process can a PR reviewer use to test or verify this change?
---

Run the focused `tari_core` unit tests above and inspect
`base_layer/core/src/base_node/state_machine_service/states/listening.rs`
to confirm peer chain metadata is aggregated into one timed `DEBUG`
summary and cleared after each log.

Breaking Changes
---

- [x] None
- [ ] Requires data directory on base node to be deleted
- [ ] Requires hard fork
- [ ] Other - Please specify

296 of 342 new or added lines in 1 file covered. (86.55%)

1233 existing lines in 26 files now uncovered.

71330 of 117076 relevant lines covered (60.93%)

535047.04 hits per line

Uncovered Changes

Lines Coverage ∆ File
46
75.0
 18.23% base_layer/core/src/base_node/state_machine_service/states/listening.rs

Coverage Regressions

Lines Coverage ∆ File
369
44.4
 -8.8% base_layer/core/src/chain_storage/lmdb_db/lmdb_db.rs
265
26.48
 -50.48% base_layer/core/src/base_node/rpc/query_service.rs
228
47.54
 -6.4% base_layer/core/src/chain_storage/blockchain_database.rs
125
6.53
 -13.6% base_layer/core/src/base_node/sync/horizon_state_sync/synchronizer.rs
32
55.16
 -9.44% base_layer/core/src/chain_storage/db_transaction.rs
32
67.84
 -4.17% base_layer/core/src/test_helpers/blockchain.rs
25
66.75
 -6.2% base_layer/core/src/chain_storage/lmdb_db/lmdb.rs
23
13.64
 -33.33% base_layer/core/src/chain_storage/block_add_result.rs
21
57.54
 -11.73% base_layer/core/src/chain_storage/async_db.rs
20
68.27
 -19.23% base_layer/transaction_components/src/transaction_components/side_chain/validator_node_registration.rs
16
9.59
 -21.92% base_layer/transaction_components/src/transaction_components/side_chain/sidechain_feature.rs
12
85.65
 -1.38% base_layer/core/src/chain_storage/lmdb_db/validator_node_store.rs
11
50.0
 -50.0% base_layer/core/src/chain_storage/smt_hasher.rs
11
56.34
 -2.14% comms/dht/src/connectivity/mod.rs
9
93.96
 -0.95% base_layer/transaction_components/src/consensus/consensus_constants.rs
6
80.3
 -9.09% base_layer/common_types/src/types/fixed_hash.rs
6
60.47
 -13.95% base_layer/node_components/src/blocks/historical_block.rs
6
92.14
 -1.27% comms/dht/src/outbound/broadcast.rs
4
88.64
 -4.55% base_layer/core/src/test_helpers/block_spec.rs
3
28.57
 -14.29% base_layer/common_types/src/epoch.rs
3
44.16
 -3.9% base_layer/core/src/validation/mocks.rs
2
81.36
 -3.39% comms/core/src/pipeline/outbound.rs
1
75.0
 18.23% base_layer/core/src/base_node/state_machine_service/states/listening.rs
1
93.76
 -0.19% base_layer/core/src/proof_of_work/monero_rx/merkle_tree.rs
1
94.79
 0.0% base_layer/transaction_components/src/consensus/consensus_encoding/hashing.rs
1
61.78
 1.39% comms/core/src/connectivity/manager.rs
Jobs
ID Job ID Ran Files Coverage
1 28609564555.1 702
60.93
 GitHub Action Run
Source Files on build 28609564555