Freegle / Iznik / 25579

73%

master: 72%

Build Type

Pull #1007

circleci

Committed by edwh

Commit Message

fix(coverage): stop SpinButton onConfirmClosed flipping Playwright coverage

Coveralls playwright "coverage decreased" reds on unrelated PRs (e.g. #1006,
config-only) were pinpointed via per-line Coveralls data to ONE line:
SpinButton.vue's onConfirmClosed body. Master's baseline run happened to
dismiss a SpinButton confirm dialog; the PR run didn't - whether any e2e test
takes the dismiss (not confirm) path varies run to run. Same class as the
finishSpinner timeout reset fixed in PR #910; the residual instance predicted
there turned out to be in SpinButton itself, not LoginModal.

Two-part fix mirroring #910: /* v8 ignore next */ so monocart/Playwright
coverage no longer samples the line, plus a unit test that covers the
dismiss path deterministically in vitest (istanbul ignores v8 comments, so
the line stays counted there). Test follows the proven PostPhoto.spec.js
pattern for stubbing the async ConfirmModal and emitting hidden.

eslint + prettier clean on both files.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_014V1ihELPDZSe3CWT461fyK

Pull Request Pull Request #1007: fix(coverage): stop SpinButton onConfirmClosed flipping Playwright coverage

Coverage Stats

12898 of 16983 branches covered (75.95%)

Branch coverage included in aggregate %.

6 of 6 new or added lines in 1 file covered. (100.0%)

2 existing lines in 1 file now uncovered.

134694 of 186173 relevant lines covered (72.35%)

38.34 hits per line