ruby-grape / grape / 28924633946

97%

master: 97%

push

github

Compare the base API, not to_s, when refreshing a mounted app

`refresh_already_mounted` deduplicates endpoints for the "same" mounted
app by comparing `endpoint.mounted_app.to_s == app.to_s`. That only works
by accident: `mount` turns every mounted Grape API into a throwaway
`mount_instance` (a fresh `Class.new(@base_parent)` per mount), so two
mounts of the same API are distinct objects, and `Grape::API::Instance`
delegates `to_s` to its `@base` (the original API). The comparison is
really "same base API", done through a string proxy -- brittle (two APIs
that happen to share a name collide) and unclear.

Expose the base API via a reader and compare it by identity instead. Plain
Rack apps have no base and are mounted as-is, so they fall back to object
identity.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

1129 of 1224 branches covered (92.24%)

Branch coverage included in aggregate %.

5 of 5 new or added lines in 2 files covered. (100.0%)

3595 of 3663 relevant lines covered (98.14%)

23333.96 hits per line