dnsimple / dns_erlang / 28922071986

88%

push

github

Reject NOTIFY with invalid counts instead of crashing (#130)

* Reject NOTIFY with invalid counts instead of crashing

decode_query/1 only handled NOTIFY (opcode 4) with QDCOUNT=1. A NOTIFY
with any other question count (e.g. QDCOUNT=256 from malformed traffic)
matched no case clause and raised case_clause, e.g. {case_clause,
{0,0,4,256,1,0,0}} for {QR,TC,OC,QC,ANC,AUC,ADC}.

Add a NOTIFY catch-all that returns formerr, mirroring the existing
QUERY/UPDATE handling, so the case is total. Adds a regression test
covering the exact header from the observed crash.

* Update Changelog

1 of 1 new or added line in 1 file covered. (100.0%)

2757 of 3121 relevant lines covered (88.34%)

11043.29 hits per line