iotaledger / iota / 28910991576
69%

DEFAULT BRANCH: develop
Ran
Jobs 1
Files 1110
Run time 3min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 68.04% (+0.003%) from 68.037%
28910991576

push

github

web-flow 
fix(iota-kvstore): use latest version of iota-bigtable crate (#12014)

# Description of change

This PR bumps the `iota-bigtable` dependency to the latest revision,
which adds handling for the transient connection errors that arise when
Google BigTable recycles long-lived gRPC connections.

Previously the client had no retry, so requests in flight on a recycled
connection failed and were surfaced as dropped queries to callers. The
updated `iota-bigtable` retries these transient errors with exponential
backoff and adds a small connection pool to reduce the blast radius of a
single reset.
  
More information is available in the corresponding PR:
https://github.com/iotaledger/iota-bigtable/pull/13

> [!NOTE]
> For now we pin the commit hash, once the `iota-bigtable` PR is merged,
a new tag will be created and used in place of the commit hash.

## Links to any relevant issues

fixes #11978 

## How the change has been tested

- [x] Basic tests (linting, compilation, formatting, unit/integration
tests)
- [ ] Patch-specific tests (correctness, functionality coverage)

- Ran locally on mainnet the iota-rest-kv with updated bigtable,
ensuring the added connection pool didn't cause any unwanted behavior.
- Checked that backoff was triggered correctly.
- Was not able to receive the errors which in first place started this
issue since BigTable connection reset can happen randomly, this isn't
conclusive proof.


### Infrastructure QA (only required for crates that are maintained by
@iotaledger/infrastructure)

> [!NOTE]
> This patch does not affect the normal ingestion operation of the
iota-indexer, thus no further tests were conducted.

0 of 4 new or added lines in 3 files covered. (0.0%)

604 existing lines in 41 files now uncovered.

161000 of 236626 relevant lines covered (68.04%)

462244.91 hits per line

Uncovered Changes

Lines Coverage ∆ File
2
0.0
 0.0% crates/iota-kvstore/src/main.rs
1
0.0
 0.0% crates/iota-data-ingestion/src/main.rs
1
0.0
 0.0% crates/iota-rest-kv/src/bigtable.rs

Coverage Regressions

Lines Coverage ∆ File
109
77.3
 0.0% crates/iota-core/src/checkpoints/mod.rs
94
84.29
 0.0% crates/iota-node/src/lib.rs
50
88.75
 0.46% crates/iota-types/src/messages_checkpoint.rs
36
90.16
 0.12% crates/iota-grpc-server/src/types.rs
33
53.42
 -0.01% crates/iota-types/src/iota_sdk_types_conversions.rs
30
23.66
 0.0% crates/iota-json-rpc-types/src/iota_checkpoint.rs
24
75.22
 0.0% crates/test-cluster/src/lib.rs
23
66.24
 -0.71% crates/iota-types/src/storage/shared_in_memory_store.rs
21
87.27
 0.0% crates/iota-core/src/checkpoints/checkpoint_executor/utils.rs
20
82.13
 0.0% crates/iota-tool/src/genesis_ceremony.rs
19
86.38
 0.0% crates/iota-types/src/test_checkpoint_data_builder.rs
16
90.87
 0.0% crates/iota-core/src/checkpoints/checkpoint_executor/mod.rs
14
88.13
 -1.08% crates/iota-test-transaction-builder/src/lib.rs
10
89.53
 -1.18% crates/iota-network/src/state_sync/mod.rs
10
44.16
 -12.99% crates/iota-types/src/messages_grpc.rs
8
46.76
 -1.37% crates/iota-sdk/src/apis/read.rs
7
79.17
 -4.17% crates/iota-config/src/transaction_deny_config.rs
6
81.9
 -0.19% crates/iota-core/src/authority.rs
6
84.17
 -1.44% crates/iota-core/src/storage.rs
6
39.6
 -5.94% crates/iota-json-rpc-types/src/object_changes.rs
6
74.73
 -1.08% crates/iota-sdk/src/wallet_context.rs
5
55.77
 -9.62% crates/iota-json-rpc-types/src/iota_coin.rs
5
86.3
 -0.17% crates/iota-transaction-builder/src/lib.rs
5
56.1
 -4.07% crates/iota-transaction-builder/src/package.rs
4
70.52
 -0.33% crates/iota-core/src/authority/authority_store.rs
4
42.86
 0.0% crates/iota-core/src/checkpoints/checkpoint_output.rs
4
73.68
 0.0% crates/iota-data-ingestion-core/src/executor.rs
4
56.64
 -0.56% crates/iota-json-rpc-types/src/iota_object.rs
4
85.51
 -5.8% crates/iota-types/src/quorum_driver_types.rs
3
87.25
 -1.2% crates/iota-core/src/authority_server/mod.rs
3
84.21
 -3.16% crates/starfish/config/src/crypto.rs
2
90.96
 -0.08% crates/iota-core/src/authority/authority_per_epoch_store.rs
2
93.43
 -0.24% crates/iota-core/src/consensus_adapter.rs
2
73.77
 -3.28% crates/iota-core/src/traffic_controller/nodefw_test_server.rs
2
74.6
 0.0% crates/iota-network/src/randomness/mod.rs
2
67.5
 0.0% crates/iota-types/src/epoch_data.rs
1
91.57
 -0.06% crates/iota-core/src/execution_cache/writeback_cache.rs
1
84.24
 0.0% crates/iota-json-rpc/src/read_api.rs
1
95.65
 -4.35% crates/iota-keys/src/random_names.rs
1
93.77
 -0.04% crates/starfish/core/src/authority_service.rs
1
98.07
 -0.1% crates/starfish/core/src/cordial_knowledge.rs
Jobs
ID Job ID Ran Files Coverage
1 nextest+simtest - 28910991576.1 1110
68.04
 GitHub Action Run
Source Files on build 28910991576