medplum / medplum / 28903349822

92%

main: 92%

push

github

Prefer complete over example CodeSystem and skip retired resources (#9741)

When multiple terminology resources share a URL, `findTerminologyResource`
selected among them by version, then date, with ties broken by Project linking
order. This caused a ValueSet composed of a CodeSystem URL that had both an
"example" and a "complete" CodeSystem in the same Project to select the wrong
one -- e.g. us-core-provider-role picking up only the 4 example
nucc.org/provider-taxonomy codes, because the example CodeSystem had a more
recent date.

Changes:
- Move candidate sorting out of SQL and into `compareTerminologyResources`, so
  the ordering is easier to reason about and extend (e.g. semver-aware version
  comparison later). Preference order is: most current version (a missing
  version is assumed current), then more complete content for CodeSystems
  ('complete' over 'example', etc.), then most recent date. Content now breaks
  ties between equal versions -- so a complete CodeSystem is preferred over an
  example one even when the example has a more recent date -- while version
  remains the primary selector.
- Exclude retired resources from selection entirely, so deactivating a
  duplicate CodeSystem/ValueSet by setting status to `retired` removes it from
  consideration.

Signed-off-by: maddyli <maddy@medplum.com>
Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>

21717 of 24669 branches covered (88.03%)

Branch coverage included in aggregate %.

18 of 20 new or added lines in 1 file covered. (90.0%)

38665 of 41018 relevant lines covered (94.26%)

12531.01 hits per line