decentraland / world-storage-service / 28898748893

99%

main: 99%

Pull #112

github

fix: harden storage delegation verification (review round 2)

B1: guard a JSON 'null'/primitive payload before destructuring — previously threw a TypeError out of verifyStorageDelegation (attacker-triggerable 500, and broke owner/deployer fall-through for any request carrying a bogus scope header).

D1: gate the scoped-delegation branch behind a new allowScopedDelegation option, enabled ONLY on authorizationMiddleware (/values/*). Env routes (authorizedAddressesOnly) no longer accept a delegation, so a scoped worker ephemeral can't read env secrets.

H6: parseClaim now requires exactly the known field lines (rejects unknown/duplicate/missing) so minter/verifier format drift fails closed. H7: filter empty trusted signers so a blank AUTHORITATIVE_SERVER_ADDRESS yields no signer (fail closed).

424 of 438 branches covered (96.8%)

Branch coverage included in aggregate %.

68 of 68 new or added lines in 2 files covered. (100.0%)

1145 of 1151 relevant lines covered (99.48%)

69.53 hits per line