kobotoolbox / kpi / 28894252322

81%

master: 76%

push

github

fix(dataTable): duplicate column and broken Open button DEV-2404 (#7220)

### 📣 Summary

Fixed Single Processing opening for audio responses when attachment
metadata has an empty question path, and prevented duplicate audio
columns in Project → Data → Table when old submission paths differ from
the current form schema.

### 💭 Notes

Changes here:

- `index.tsx`: for audio cells, fallback to the schema xpath when
attachment question path is empty, so Open does not navigate to a broken
processing route.
- `tableUtils.ts`: in `getAllDataColumns`, dedupe stale audio keys from
submissions when the current survey already contains the matching audio
question path.
- `tableUtils.tests.ts`: added regression coverage to ensure current
audio xpath is preferred and stale duplicate xpath is excluded.

### 👀 Preview steps

1. Open a project with audio questions and submissions where at least
one attachment has an empty question path value (not sure how to achieve
it yet).
2. Go to Project → Data → Table.
3. Find an audio response row and use "Open" button.
4. 🔴 On main: for affected attachments, "Open" may navigate to a broken
processing URL.
5. 🟢 On this PR: Open navigates to the expected Single Processing route
using a safe xpath fallback.
6. In the same table, check columns for an audio question that exists
under an old submission path and a current schema path.
7. 🔴 On main: duplicate audio columns may appear.
8. 🟢 On this PR: only the current survey audio column is shown; stale
duplicate path column is not shown.

---------

Co-authored-by: Paulo Amorim <pauloamorimbr@gmail.com>

8944 of 12168 branches covered (73.5%)

29331 of 36027 relevant lines covered (81.41%)

5.57 hits per line