MushroomObserver / mushroom-observer / 28882362678

99%

main: 99%

Build Type

Pull #4719

github

Committed by JoeCohen

Commit Message

Fix handling of licensed param in URL

- Fixes superimporter "import others" confirm counts and unlicensed-obs handling

The confirm page miscounted Requested/Expected/Already-imported when a superimporter's URL filtered on `licensed=false`, and unlicensed observations were misclassified as "already imported" instead of their own category.

- `URLNormalizer` no longer strips `licensed` from the URL, so estimates reflect the user's actual request.
- `Estimators` adds `not_yet_imported`/`licensed_explicitly_false?` so Expected/Total Ignored short-circuit correctly instead of querying an unrelated population.
- `PageParser#add_ownership_filter` now defaults `licensed:true` instead of always overriding it.
- `ObservationImporter#unlicensed_other?` is the real safety net: for import-others, an obs with no iNat license is skipped entirely (new `ignored_unlicensed_count`), while individual unlicensed photos on an otherwise-licensed obs are still skipped per-image as before.
- Confirm page moves the unlicensed count into the Ignored Observations breakdown for import-others.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>

Pull Request Pull Request #4719: Fix handling of licensed param in URL

Coverage Stats

42 of 42 new or added lines in 8 files covered. (100.0%)

29 existing lines in 11 files now uncovered.

51710 of 52207 relevant lines covered (99.05%)

754.76 hits per line