gauntface / go-html-asset-manager / 28877589298

67%

push

github

Fix youtubeclean/vimeoclean aborting the whole page on one bad iframe (#749)

* Fix Cache-Control header on S3 image uploads

cacheControlAge is a *int64 (from flag.Int64), but uploadImage() passed
it un-dereferenced to fmt.Sprintf("max-age=%v", ...), so every image
uploaded to S3 got a Cache-Control header like "max-age=0xc0000140a0"
(the pointer address) instead of a real max-age value.

Extracts the header construction into a small cacheControlHeader()
helper so it's unit-testable, and dereferences the flag value.

go.sum gains a handful of previously-missing checksum entries for
transitive test/tooling deps, surfaced by `go build`/`go test` on this
otherwise-unmodified dependency graph.

* Fix youtubeclean/vimeoclean aborting the whole page on one bad iframe

Both manipulators used `return nil`/`return err` from inside a
`for _, ele := range els` loop for checks that should only skip *that*
iframe (missing src, wrong host, no path match, no configured sizes, a
failed URL parse, a failed Vimeo API lookup). Since manipulateHTMLFile
stops running the remaining manipulators the moment one returns an
error, this bug had two layers of blast radius:

- Any element after the first non-matching/failing iframe on the page
  never got checked, even other legitimate YouTube/Vimeo embeds.
- A malformed embed URL or a transient Vimeo API failure aborted not
  just this manipulator but every later manipulator in the pipeline
  (image sizing, lazyload, CSS/JS injection, etc.) for that entire file.

All early exits are now `continue`, including the URL-parse and Vimeo
API failure cases: a broken embed is now left as-is and the rest of the
page's pipeline still runs, rather than only converting embeds before
the first bad one and abandoning everything else in the file.

`errURLParse` is no longer used by either manipulator now that parse
failures are skipped rather than surfaced as an error, so it's removed.

Existing tests only ever used single-iframe documents, s... (continued)

13 of 13 new or added lines in 2 files covered. (100.0%)

1710 of 2535 relevant lines covered (67.46%)

11.57 hits per line