gauntface / go-html-asset-manager / 28876362811

67%

push

github

Fix Cache-Control header on S3 image uploads (#748)

cacheControlAge is a *int64 (from flag.Int64), but uploadImage() passed
it un-dereferenced to fmt.Sprintf("max-age=%v", ...), so every image
uploaded to S3 got a Cache-Control header like "max-age=0xc0000140a0"
(the pointer address) instead of a real max-age value.

Extracts the header construction into a small cacheControlHeader()
helper so it's unit-testable, and dereferences the flag value.

go.sum gains a handful of previously-missing checksum entries for
transitive test/tooling deps, surfaced by `go build`/`go test` on this
otherwise-unmodified dependency graph.

3 of 4 new or added lines in 1 file covered. (75.0%)

1723 of 2548 relevant lines covered (67.62%)

11.36 hits per line