rero / rero-ils / 28779774833

91%

staging: 91%

Build Type

push

github

Committed by PascalRepond

Commit Message

fix(acquisition): allow cancelling the last non-received order line

Cancelling the last non-received line of a partially received order makes
the order fully received. The REST PUT calls the record's overridden
update() (which commits and reindexes), then invenio commits again and
re-runs extended_validation, which then saw the order as RECEIVED and
rejected it with "wrong status" -- even though the cancellation had
already persisted, leaving the line cancelled but surfacing an error.

Accept RECEIVED in extended_validation when the line is being cancelled:
a cancellation is always valid, and the update permission (evaluated once
on the prior status) remains the real gate. Also fix and translate the validation
docstring (it omitted the order-status check and claimed a False return)
and reword the message to "save" instead of "create" so it no longer
implies a creation on updates.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-Authored-by: Pascal Repond <pascal.repond@rero.ch>

Coverage Stats

3 of 3 new or added lines in 1 file covered. (100.0%)

20 existing lines in 6 files now uncovered.

24249 of 26551 relevant lines covered (91.33%)

0.91 hits per line