dangernoodle-io / breadboard / 28810291452

100%

push

github

fix: start bb_cache eviction sweep via bb_init PRE_HTTP hook (#757)

- register bb_cache_evict_start (bb_err_t, matches bb_init's PRE_HTTP
  signature directly -- no adapter needed) as a PRE_HTTP bb_init hook,
  gated on CONFIG_BB_CACHE_SWEEP_ENABLE, mirroring bb_pub_start -- the
  knob previously compiled the sweep in but nothing ever called it, so
  age-out eviction's on_remove never fired
- add the matching bb_init_force_register_pre_http + bb_init/bb_timer
  PRIV_REQUIRES to components/bb_cache/CMakeLists.txt, scoped to the
  ESP-IDF build only (the portable component and host platform stay on
  pure lazy ensure_init); both deps are unconditional PRIV_REQUIRES
  rather than gated behind the Kconfig -- idf_component_register's
  requirements are expanded in an early pass that runs before Kconfig
  values are resolved, so a Kconfig-conditional REQUIRES silently
  resolves as unset regardless of the real value (confirmed empirically;
  matches the existing bb_pub_fan/bb_alert convention of always
  requiring an optional dep and gating only the runtime registration
  call, which does see the real Kconfig value)
- internalize bb_cache_evict_start as static (zero external callers) and
  drop its public declaration + no-op header stub -- the Kconfig knob is
  now the only control
- run the sweep on a dedicated bb_timer_worker task (firmware-review fix)
  instead of a raw pthread_create() + manual usleep() loop -- the sweep's
  call chain now reaches an arbitrary consumer on_remove callback, which
  is unsafe on the ESP-IDF pthread default stack (~3072 B); the worker is
  sized via CONFIG_BB_CACHE_SWEEP_WORKER_STACK (default 8192, matching
  bb_pub's TLS-tier worker), named "bb_cache_evict" for /api/diag/tasks,
  and its create/start return values are checked so a failure is logged
  and never leaves the started-state lying
- move the bb_init.h/bb_timer.h includes to the top-of-file include block
  (gated on BB_CACHE_SWEEP_ENABLE) instead of mid-file, and... (continued)

3311 of 3311 branches covered (100.0%)

Branch coverage included in aggregate %.

5179 of 5179 relevant lines covered (100.0%)

10199.95 hits per line