MushroomObserver / mushroom-observer / 28806174439

99%

main: 99%

Build Type

Pull #4702

github

Committed by JoeCohen

Commit Message

Halt daily "reviewed observation  (insert)"

- Skips votes with nil observation in refresh_caches
- Creates script to clean up production db

`Vote.add_missing_views_corresponding_to_votes` was reprocessing votes whose `observation_id` is NULL every night, because `NULL = NULL` never matches in the LEFT JOIN against `observation_views`. This produced the daily blank "User X has reviewed observation  (insert)." lines in the `refresh_caches` email and had silently accumulated 2,310 junk `observation_views` rows with `observation_id: NULL` in the database.
Added `cache:remove_orphaned_observation_views` to clean up the existing junk rows; this task must be run manually against production once this deploys.

Pull Request Pull Request #4702: Halt daily "reviewed observation (insert)"

Coverage Stats

1 of 1 new or added line in 1 file covered. (100.0%)

28 existing lines in 23 files now uncovered.

51658 of 52376 relevant lines covered (98.63%)

748.45 hits per line