source-academy / py-slang / 28806044086

78%

push

github

Cleanly skip complex-number test cases in the native Pynter parity harness (#219)

* Cleanly skip complex-number test cases in the native Pynter parity harness

Pynter's VM has no complex number type at all (it mirrors Sinter: values
are booleans, 32-bit ints, or single-precision floats only), and
py-slang's own PVML compiler rejects complex literals outright
(PVMLCompiler.visitComplexExpr throws unconditionally). Every test case
whose code contains a complex literal was therefore always failing to
compile — previously surfacing as either a genuine test failure, or, for
cases expecting an error class, a coincidental "pass" (any thrown error,
including this unrelated compile failure, satisfied the loose
"threw *some* error" check).

Detect and skip these cases explicitly instead: involvesComplexNumbers()
checks the expected value's type (PyComplexNumber) or a complex-literal
regex over the source (since a case can involve a complex number as an
intermediate value without one being the final expected result, e.g. a
comparison or an error case like `arity(1+0j)` expecting TypeError).
generateNativePynterTestCases() now partitions each group's cases into
`supported` (run normally) and `unsupportedComplex` (test.skip.each, with
a label saying why), so they show up individually as clean skips rather
than muddying the pass/fail counts.

Net effect on the stdlib suite: 226 cases move out of the pass/fail
tally (96 were coincidental passes as above, 130 were genuine failures);
every other suite (global-keyword, nonlocal, loops, linked-list,
pairmutator, list, stream) is untouched, having no complex-number cases;
parser-stdlib loses 2 cases the same way. Verified against a local Pynter
build: stdlib 408/685 attempted (was misleadingly 504/911), parser-stdlib
12/95 attempted (was 12/97), all other suites unchanged, and the full
suite still reports the same 1300 skipped with PYNTER_RUNNER_PATH unset
(confirming no behavior change when the harness itself is inacti... (continued)

2475 of 3479 branches covered (71.14%)

Branch coverage included in aggregate %.

15 of 15 new or added lines in 1 file covered. (100.0%)

5979 of 7432 relevant lines covered (80.45%)

13479.29 hits per line