source-academy / py-slang / 28802687945

81%

push

github

Finish renaming remaining Sinter/SVML remnants to Pynter/PVML (#218)

* Finish renaming the last Sinter/SVML remnants: opcode constant, WASM evaluator

- SINTER_OPCODE_MAX -> PYNTER_OPCODE_MAX in src/engines/pvml/opcodes.ts,
  and its two use sites (src/pvml-runner.ts, the WASM evaluator below).
  It's a shared constant (0x54, the real Sinter/SVML binary format's
  actual max opcode) used by both the native Pynter pathway and the
  in-browser WASM one; renaming it to PYNTER_OPCODE_MAX matches the
  aggressive-rename direction, since Pynter is presently identical to
  Sinter anyway.
- src/conductor/PySvmlSinterEvaluator.ts -> PyPvmlPynterEvaluator.ts
  (class and file), updated in src/conductor/index.ts, scripts/build.ts,
  and README.md.
- Merged src/engines/pvml/sinter/ into src/engines/pvml/pynter/
  (alongside the existing native-pynter.ts), renaming sinter.ts ->
  pynter-wasm.ts and sinterwasm.{js,wasm,d.ts,wasm.d.ts} ->
  pynterwasm.{js,wasm,d.ts,wasm.d.ts}. Renamed the TS-level exports
  (SinterValue -> PynterValue, SinterModule -> PynterModule, initSinter
  -> initPynter) and updated rollup.config.mjs's commonjs() include path
  accordingly. Left untouched: the actual compiled .wasm bytes and the
  cwrap() symbol strings ("siwasm_alloc_heap" etc.) baked into
  pynterwasm.js, since those are real, unmodified WASM-exported function
  names from Pynter's own "si"-prefix convention (see pynter-wasm.ts's
  new comment) — renaming those would require rebuilding the WASM binary
  from source, not just a text rename. The vendored WASM binary itself
  is also still literally built from Sinter's real source (Pynter is
  presently an unmodified fork), which the folder's wasm-README.md now
  says explicitly.

Verified: yarn tsc --noEmit, full jest suite (2401 passed, 1300 skipped,
0 failed), and both yarn build --evaluator PyPvmlEvaluator and
yarn build --evaluator PyPvmlPynterEvaluator (the WASM one, exercising
the rollup.config.mjs path fix) build clean.... (continued)

2469 of 3473 branches covered (71.09%)

Branch coverage included in aggregate %.

3 of 5 new or added lines in 2 files covered. (60.0%)

5965 of 7418 relevant lines covered (80.41%)

13502.87 hits per line